Skip to content

Comments

workspaceFolder is not supported yet#578

Merged
lecoursen merged 5 commits intogithub:mainfrom
mtsmfm:patch-1
Nov 5, 2020
Merged

workspaceFolder is not supported yet#578
lecoursen merged 5 commits intogithub:mainfrom
mtsmfm:patch-1

Conversation

@mtsmfm
Copy link
Contributor

@mtsmfm mtsmfm commented Oct 16, 2020 •
edited
Loading

@welcome
Copy link

welcome bot commented Oct 16, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 16, 2020
@janiceilene
Copy link
Contributor

janiceilene commented Oct 16, 2020

@mtsmfm Thank you so much for opening a PR! I'll get this triaged for review ⚡

@jkeech jkeech requested a review from matthewisabel October 16, 2020 17:20
@jkeech
Copy link
Contributor

jkeech commented Oct 16, 2020

@matthewisabel, there are several properties in this list that are not supported in Codespaces:

Not yet supported

  • workspaceMount
  • workspaceFolder

Not applicable for Codespaces (no plan to support)

  • devPort
  • updateRemoteUserUID
  • shutdownAction

VS Code's devcontainer documentation is closer to being correct -- there are some comments about which properties are not supported in Codespaces or if they behave slightly differently in Codespaces: https://code.visualstudio.com/docs/remote/devcontainerjson-reference

cc @Chuxel

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Oct 24, 2020
@mtsmfm
Copy link
Contributor Author

mtsmfm commented Oct 25, 2020

@janiceilene @jkeech I've updated the doc to follow the comment

#578 (comment)

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Oct 25, 2020
@janiceilene janiceilene added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 27, 2020
lecoursen
lecoursen reviewed Nov 4, 2020
View reviewed changes
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for letting us know about these unsupported keys! I added a few suggested changes for the best way to convey that information. After you commit those suggestions, I can approve and merge! 😎 🎉

mtsmfm and others added 2 commits November 5, 2020 06:42
@mtsmfm @lecoursen
Update content/github/developing-online-with-codespaces/configuring-c…
10e6233 
…odespaces-for-your-project.md

Co-authored-by: Laura Coursen <lecoursen@github.com>
@mtsmfm @lecoursen
Update content/github/developing-online-with-codespaces/configuring-c…
90eae2e 
…odespaces-for-your-project.md

Co-authored-by: Laura Coursen <lecoursen@github.com>
@mtsmfm
Copy link
Contributor Author

mtsmfm commented Nov 4, 2020

@lecoursen Applied your suggestions

@lecoursen lecoursen merged commit b1dc16d into github:main Nov 5, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@Chantall1602 Chantall1602 mentioned this pull request Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lecoursen lecoursen lecoursen approved these changes

+1 more reviewer

@matthewisabel matthewisabel matthewisabel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mtsmfm @janiceilene @jkeech @matthewisabel @lecoursen